----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68968/#review209429 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java Lines 124 (patched) <https://reviews.apache.org/r/68968/#comment293831> We should use different metric for "granting" vs "update" since update is much more complicated and would take more time. Once we support "revoke" owner privilege, we can add a metric for that. - Na Li On Oct. 9, 2018, 6:01 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68968/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2018, 6:01 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2425 > https://issues.apache.org/jira/browse/SENTRY-2425 > > > Repository: sentry > > > Description > ------- > > New metric should be added to track the time taken by sentry server in > granting/updating owner privileges. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > d34340cd6a41ba01943bd3b2b42c9bddc9fa722f > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 709434c388689b63d5db7d71cd6cc47952d647bf > > > Diff: https://reviews.apache.org/r/68968/diff/1/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
