----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209865 -----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java Lines 152 (patched) <https://reviews.apache.org/r/68973/#comment294471> how can we make this variable name to not be confused with threads fetching an hms snapshot? sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java Lines 153 (patched) <https://reviews.apache.org/r/68973/#comment294481> is there an optimal value higher than 2 to make it faster? sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3476-3479 (original), 3491-3494 (patched) <https://reviews.apache.org/r/68973/#comment294476> I wonder how much memory do we expect in the worst case scenarios to be hold in memory for all these objects in the pool? In the previous patchthe objects were persisted (1 at a time), and GC could collected them. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 3478 (original), 3493 (patched) <https://reviews.apache.org/r/68973/#comment294483> This is executed in a different transaction? sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 3481 (original), 3496 (patched) <https://reviews.apache.org/r/68973/#comment294480> Shouldn't we destroy or stop the persisting process of the rest of the paths if the persistingSnapshotFailed is true? sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3510 (patched) <https://reviews.apache.org/r/68973/#comment294478> Aren't these deleted during the rollback? sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 5106-5112 (patched) <https://reviews.apache.org/r/68973/#comment294482> How often does this code get ID conflicts while persisting in a threaded process? Isn't this going to make the persisting slow? - Sergio Pena On Oct. 22, 2018, 2:42 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68973/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2018, 2:42 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2305 > https://issues.apache.org/jira/browse/SENTRY-2305 > > > Repository: sentry > > > Description > ------- > > I have considered multiple options. Persisting in batches is not an option > with out changing the schema as the data nucleus does not persist row in > batches for tables which have foreign key on other tables. > > I see that best option is to persist the paths in parallel. It gave good > results. > > Solution Approach: > > I have used a thread pool to persist the snapshot. Size of this thread pool > is configurable. Paths for each object database/table are submitted to this > thread pool. If for reason some of the paths are not pesisted, snapshot is > removed and exception is throw back. > > This patch along with SENTRY-2423 was 5 times faster when tested with below. > > > > Object Type Count > Databases 209 > Tables 2100 > Partitions 200004 > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > 092060c450c6a906850630cb10454737157af5fe > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > b387a22e40b8958395e1c12af12272b89a778726 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java > 0d62941a7bd45e0d8a67b5d95fdb39a8801f5a26 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 4a9afe303672baff39be01d4f190034b2bfb75fe > > > Diff: https://reviews.apache.org/r/68973/diff/5/ > > > Testing > ------- > > Added new test and also made sure that existing tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
