----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69175/ -----------------------------------------------------------
(Updated Oct. 29, 2018, 5:07 p.m.) Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Bugs: sentry-2433 https://issues.apache.org/jira/browse/sentry-2433 Repository: sentry Description ------- 1) use PermissionsUpdate.ALL_PRIVS in "1.1) NotificationProcessor.java static Update getPermUpdatableOnDrop(TSentryAuthorizable authorizable)" and "SentryPlugin.java public Update onDropSentryPrivilege(TDropPrivilegesRequest request)" instead of "PermissionsUpdate.ALL_ROLES" 2) check PermissionsUpdate.ALL_PRIVS instead of PermissionsUpdate.ALL_ROLES in UpdateableAuthzPermissions.applyPrivilegeUpdates() in "pUpdate.getDelPrivileges()" processing. Diffs (updated) ----- sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java c87d205 sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 0f3c162 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java 7b7d0e1 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java 29d2256 Diff: https://reviews.apache.org/r/69175/diff/2/ Changes: https://reviews.apache.org/r/69175/diff/1-2/ Testing ------- owner privilege tests pass and add new test for external table Thanks, Na Li