-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69204/
-----------------------------------------------------------
(Updated Oct. 30, 2018, 5:39 p.m.)
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Changes
-------
Final diff for history
Bugs: SENTRY-2437
https://issues.apache.org/jira/browse/SENTRY-2437
Repository: sentry
Description
-------
Currently sentry creates a transaction for each TSentryPrivilege object it
needs to grant. If the list of privileges is very large creating a single
transaction for each significantly affects performance. This is particularly
impactful for tables with large columns and if a user grants privileges to many
of those columns
Diffs (updated)
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
01b363479
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java
97407fff5
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java
1d87b0b66
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
f2f38a38f
Diff: https://reviews.apache.org/r/69204/diff/4/
Changes: https://reviews.apache.org/r/69204/diff/3-4/
Testing
-------
$ mvn -f sentry-service/sentry-service-server/pom.xml test
-Dtest=TestSentryStore
$ mvn -f sentry-service/sentry-service-server/pom.xml test
-Dtest=TestHMSFollowerSentryStoreIntegration
Thanks,
Arjun Mishra