----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ -----------------------------------------------------------
(Updated Oct. 31, 2018, 12:58 p.m.) Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Changes ------- Fixed some issue observed in mu testing. Bugs: SENTRY-2249 https://issues.apache.org/jira/browse/SENTRY-2249 Repository: sentry Description ------- Currently each entry in full snapshot of HMS is persisted one entry at a time. Instead it could be optimized by persisting the path entries in batches. DB operations are expensive, reducing the number of database operations and around trip time will help. This would decrease the time to persist the snapshot in to database significantly. Size of the batch could be configurable. This patch will change with SENTRY-2305. This review request is just to give you a sence of the change. Diffs (updated) ----- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java d8c1061d36ed0b92116f0b2dd5ec820ccb166818 sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java 092060c450c6a906850630cb10454737157af5fe sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java c51f25a0393b482814afcd3b7a19e547b689ac6e sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MPathToPersist.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 20ec0deab6b97065cfe99beea3d14a6c7268aac3 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 33c40613a05f7c7fde314af6aba6b269bf6ffaae Diff: https://reviews.apache.org/r/69087/diff/2/ Changes: https://reviews.apache.org/r/69087/diff/1-2/ Testing ------- Thanks, kalyan kumar kalvagadda