> On Nov. 1, 2018, 9:26 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > > Line 143 (original) > > <https://reviews.apache.org/r/69212/diff/1/?file=2103121#file2103121line145> > > > > why do you remove it? Is it impossible to throw this exception?
It's not needed. The change is not using URIUtil anymore, so there is no URI exception. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69212/#review210262 ----------------------------------------------------------- On Oct. 30, 2018, 2:16 a.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69212/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2018, 2:16 a.m.) > > > Review request for sentry and kalyan kumar kalvagadda. > > > Bugs: sentry-2329 > https://issues.apache.org/jira/browse/sentry-2329 > > > Repository: sentry > > > Description > ------- > > Bump hadoop.version to 3.1.1. The changes on Sentry are compatible with > Hadoop 2.7. > > > Diffs > ----- > > pom.xml acbdcc2722bf189811cb528ac1b2d07983a571c2 > sentry-binding/sentry-binding-solr/pom.xml > f2a5fca76d3d220fcf2b72a3179ff5218fc6577c > sentry-hdfs/sentry-hdfs-common/pom.xml > df6f04c048b502ff5f8e8ec397d75166faba8c3c > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > c9ecc4021b167d98c7dade409c97ae7d26e967ea > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java > 18b62652a11dfee6683cb8f24944ccd3d344dc9f > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithKerberos.java > 5d94d4bc6a2a47189e69556a5e4d9bdee05952a7 > > > Diff: https://reviews.apache.org/r/69212/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
