----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69285/#review210387 -----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java Lines 120 (patched) <https://reviews.apache.org/r/69285/#comment295048> Reverse these checks to match the parameter order. sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java Lines 123 (patched) <https://reviews.apache.org/r/69285/#comment295049> StringUtils.isEmpty - Steve Moist On Nov. 7, 2018, 9:57 p.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69285/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2018, 9:57 p.m.) > > > Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na > Li, Steve Moist, and Sergio Pena. > > > Bugs: SENTRY-2444 > https://issues.apache.org/jira/browse/SENTRY-2444 > > > Repository: sentry > > > Description > ------- > > SENTRY-2444: Signal Handle Unregister > > Single unregister of function from the signal handler. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java > d621c74c2cdf44c1eedbec36f5cd8a32cace20ff > > > Diff: https://reviews.apache.org/r/69285/diff/1/ > > > Testing > ------- > > Build and Unit tests > > > Thanks, > > Brian Towles > >
