----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/ -----------------------------------------------------------
Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena. Bugs: SENTRY-2458 https://issues.apache.org/jira/browse/SENTRY-2458 Repository: sentry Description ------- SENTRY-2458: Split web service from server service modules In order to additional modules to be added to Sentry there needs to be a separation of some of the features used by service-server into other modules. This will allow the web server to be pulled out from the base server and allow for additional modules to be able to add web services and functionality to the web interface without depending up the whole server module. It will use the SPI to dynamically include servlets and content from other modules. It creates a sentry-service-providers to allow for Server and sub modules SPI providers to be defined externally and not depended on directly. Diffs ----- sentry-dist/pom.xml 62558d2e042235baaa1deb05fb8144332e139bc1 sentry-dist/src/main/assembly/bin.xml 986530c550e534ac1c62853d4c5a8cb7e3ed3927 sentry-provider/sentry-provider-db/pom.xml df569474abaa6afd1d4c3dd89e8afaffbf3ae342 sentry-service/pom.xml e653189eb55bb372cef789b6de3e17378cfd4ae2 sentry-service/sentry-service-providers/pom.xml PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION sentry-service/sentry-service-server/pom.xml 44540ad5dee5d3f3c87e47f25651ba7cf631ad46 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java 8625487458539acbd279ee9264cb8fc350725938 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java af81d6fcebcdfe84f8841eaae0c5622a8791586c sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java 8da35f10f91c48826c8528f6e2b43e4e88c23c7e sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java 5dc6cd6c4f644b3c08de5ae2a5b5f8ccd1961ae2 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java 23121ecf5a711d1698cd1fba7b8491646407d819 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java befe6c3ed97d6f16f9c30451487bac7ee7dc1e6d sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java b3a4934dfc523d14eec216df00a6b7597c66c166 sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory PRE-CREATION sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css c31428b07eac6a9997dee0c6764734ff4fe84813 sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css a553c4f5e08a72a0d475aac9019fa57754abccb3 sentry-service/sentry-service-server/src/main/webapp/css/sentry.css sentry-service/sentry-service-server/src/main/webapp/sentry.png sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java 6e741e89525051b184f1ab2ce74d5b060cc6dc60 sentry-service/sentry-service-web/pom.xml PRE-CREATION sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java PRE-CREATION sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java PRE-CREATION sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap.min.css PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.svg PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.min.js PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/npm.js PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/css/materialdesignicons.min.css PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.svg PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2 PRE-CREATION Diff: https://reviews.apache.org/r/69351/diff/1/ Testing ------- Running with web and unit tests Thanks, Brian Towles