----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69415/ -----------------------------------------------------------
(Updated Nov. 30, 2018, 5:21 p.m.) Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and Sergio Pena. Changes ------- Addressed Lina's comments Bugs: SENTRY-2463 https://issues.apache.org/jira/browse/SENTRY-2463 Repository: sentry Description ------- Right now if we initially grant ALL and revoke SELECT or INSERT, the privilege gets "modified" to INSERT or SELECT. However, conversely if we initially grant SELECT or INSERT and revoke ALL, no privileges are dropped Diffs (updated) ----- sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java e2d6c85ac sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 6a7c1f392 Diff: https://reviews.apache.org/r/69415/diff/2/ Changes: https://reviews.apache.org/r/69415/diff/1-2/ Testing ------- mvn -f sentry-tests/sentry-tests-hive/pom.xml test -Dtest=TestDatabaseProvider mvn -f sentry-service/sentry-service-server/pom.xml test -Dtest=TestSentryStore Thanks, Arjun Mishra