----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/ -----------------------------------------------------------
(Updated Dec. 11, 2018, 8:16 p.m.) Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and Sergio Pena. Bugs: SENTRY-2476 https://issues.apache.org/jira/browse/SENTRY-2476 Repository: sentry Description ------- Right now when we process a drop partition event, we fetch each path object for paths_mapping object then find the one we want to delete and then delete it. We should avoid fetching all objects and directly delete the path that needs to be deleted This affects, deleteAuthzPathsMapping, renameAuthzPathsMapping, updateAuthzPathsMapping, and addAuthzPathsMappingCore methods that are known at the moment Diffs (updated) ----- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java d8c1061d3 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java f5802d701 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java e2d6c85ac sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java ca8c41610 Diff: https://reviews.apache.org/r/69530/diff/5/ Changes: https://reviews.apache.org/r/69530/diff/4-5/ Testing ------- $ mvn -f sentry-service/sentry-service-server/pom.xml test -Dtest=TestNotificationProcessor Thanks, Arjun Mishra