----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69620/#review211679 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java Lines 284 (patched) <https://reviews.apache.org/r/69620/#comment297134> if enableAuthorizingObjectStore is false, should you set METASTORE_RAW_STORE_IMPL to be ObjectStore? The default value is "org.apache.hadoop.hive.metastore.ObjectStore". Setting it here would make it more obvious what implementation is used. - Na Li On Dec. 21, 2018, 5:39 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69620/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2018, 5:39 p.m.) > > > Review request for sentry and Na Li. > > > Bugs: sentry-2483 > https://issues.apache.org/jira/browse/sentry-2483 > > > Repository: sentry > > > Description > ------- > > Add READ_DATABASE and READ_TABLE events support to provide read authorization > to HMS. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java > 328d2b5c69451922e062cc3f04d37c5e7347d17f > sentry-tests/sentry-tests-hive/pom.xml > 74777bbff590ea63c18492c77ae86042734d8e70 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 8bf486e7d7d7a2e89278f1287115bf835513ef3f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 7d41348572f0c01001b6bfa03d5ffb780f5a5e75 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > f8f304fbb9926d98939ee0aa8c74f0abc8789fa9 > > > Diff: https://reviews.apache.org/r/69620/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
