----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69841/#review212389 -----------------------------------------------------------
Ship it! Ship It! - Arjun Mishra On Jan. 28, 2019, 6:55 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69841/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2019, 6:55 p.m.) > > > Review request for sentry, Arjun Mishra, Haley Reeve, and kalyan kumar > kalvagadda. > > > Bugs: sentry-2486 > https://issues.apache.org/jira/browse/sentry-2486 > > > Repository: sentry > > > Description > ------- > > In insecure mode, the current login user name is passed from Sentry to HMS > server when sentry HMSFollower gets full snapshot from HMS. > > The user name should be "sentry" instead of current login user. > > This issue should not happen in production because secure mode is always > used. Insecure mode is only used in test. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HiveSimpleConnectionFactory.java > 31e58fd > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java > 0d62941 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > 47f7466 > > > Diff: https://reviews.apache.org/r/69841/diff/2/ > > > Testing > ------- > > Tested manually and verified the user name now is "sentry" when sentry > HMSFollower gets notifications from HMS server > > > Thanks, > > Na Li > >
