----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69975/#review212871 -----------------------------------------------------------
Ship it! Code change looks good. - kalyan kumar kalvagadda On Feb. 13, 2019, 6:46 p.m., Tristan Stevens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69975/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2019, 6:46 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Adds a conjunctive match capabiltiy to the existing > QueryDocAuthorizationComponent (which applies document level security against > Sentry roles) > > > Diffs > ----- > > sentry-solr/solr-sentry-handlers/pom.xml 621d8325 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/QueryDocAuthorizationComponent.java > 9da3d6e1 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestCase.java > 3d4d555f > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/DocLevelGenerator.java > 40cc153e > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SolrSentryServiceTestBase.java > e1f789cb > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java > 7834f339 > sentry-tests/sentry-tests-solr/src/test/resources/log4j.properties d9418167 > > > Diff: https://reviews.apache.org/r/69975/diff/1/ > > > Testing > ------- > > Unit tests added for SubsetQueryPlugin > End-to-end tests added under sentry-tests/senty-tests-solr for full > SolrCloud+Sentry Service using the new QueryDocAuthorizationComponent in > conjunctive match mode > > > Thanks, > > Tristan Stevens > >
