I'll aim to review this later today.
On Wed, Sep 18, 2013 at 9:44 AM, Brock Noland <[email protected]> wrote: > > > > On Sept. 18, 2013, 4:43 p.m., Brock Noland wrote: > > > Yay!!!!!!!!!!!!!!!!!!!! > > Sorry, don't have time to review. Just happy about the change! > > > - Brock > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14096/#review26220 > ----------------------------------------------------------- > > > On Sept. 18, 2013, 4:39 p.m., Sravya Tirukkovalur wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/14096/ > > ----------------------------------------------------------- > > > > (Updated Sept. 18, 2013, 4:39 p.m.) > > > > > > Review request for sentry. > > > > > > Repository: sentry > > > > > > Description > > ------- > > > > Complete patch, where all the tests have been changed to use the > PolicyFile class. > > > > > > Diffs > > ----- > > > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestCrossDbOps.java > 891b7c2 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestEndToEnd.java > a643e17 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestExportImportPrivileges.java > 89f7f04 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestMetadataPermissions.java > 6036eaa > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestMovingToProduction.java > dba6d9f > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPerDBConfiguration.java > 7fb7f6c > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPrivilegesAtDatabaseScope.java > 7330d4a > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPrivilegesAtFunctionScope.java > 90d6214 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPrivilegesAtTableScope.java > 21bc846 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestRuntimeMetadataRetrieval.java > 437ca03 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestSandboxOps.java > c5901b9 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestSentryOnFailureHookLoading.java > b16d00a > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestServerConfiguration.java > aaad396 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestUriPermissions.java > cd6eb14 > > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestUserManagement.java > fba3878 > > > > Diff: https://reviews.apache.org/r/14096/diff/ > > > > > > Testing > > ------- > > > > All the tests pass. > > > > > > Thanks, > > > > Sravya Tirukkovalur > > > > > >
