> On Feb. 11, 2015, 4:35 a.m., Vamsee Yarlagadda wrote: > > So looks like we are basically integrating Sentry / LilyHBaseIndexer (and > > this doesn't use existing Solr/Sentry integration). If that is the case, we > > can have lily hbase authorization running independent of whether we run > > solr authorization right (both are independent)? > > > > This is more of a future question, does the relevant handlers live in > > Sentry side or NGdata's lily hbase indexer side?
Yes, they are independent. On your future question, plan is for them to live on Sentry side, but I need to investigate more. > On Feb. 11, 2015, 4:35 a.m., Vamsee Yarlagadda wrote: > > sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/IndexerConstants.java, > > line 22 > > <https://reviews.apache.org/r/30852/diff/2/?file=860576#file860576line22> > > > > I am having trouble understanding what each indexer constant mean. Like > > for e.g does READ imply ability to read source data or ability to create an > > indexer? See the design doc in SENTRY-639 (https://issues.apache.org/jira/browse/SENTRY-639). > On Feb. 11, 2015, 4:35 a.m., Vamsee Yarlagadda wrote: > > sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/IndexerConstants.java, > > line 23 > > <https://reviews.apache.org/r/30852/diff/2/?file=860576#file860576line23> > > > > typo in "wrte" -> "write" Good catch. - Gregory ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30852/#review71922 ----------------------------------------------------------- On Feb. 10, 2015, 11:51 p.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30852/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 11:51 p.m.) > > > Review request for sentry and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Pretty straightforward translation from search to indexer model. > > > Diffs > ----- > > pom.xml 60a9f4aa16b67a929534895cd3aed18c6eab383b > sentry-core/pom.xml 2dce738c5d9bf043444d9e5ebc7c7975513600c7 > sentry-core/sentry-core-model-indexer/pom.xml PRE-CREATION > > sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/Indexer.java > PRE-CREATION > > sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/IndexerActionFactory.java > PRE-CREATION > > sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/IndexerConstants.java > PRE-CREATION > > sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/IndexerModelAction.java > PRE-CREATION > > sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/IndexerModelAuthorizable.java > PRE-CREATION > > sentry-core/sentry-core-model-indexer/src/test/java/org/apache/sentry/core/indexer/TestIndexerBitFieldAction.java > PRE-CREATION > sentry-core/sentry-core-model-search/pom.xml > 1753b516d82069e9a1600f51eb94d9ef99e8c97f > sentry-dist/pom.xml 04a63def18198c7b2df98faa34d3ded5f6be7bf9 > > Diff: https://reviews.apache.org/r/30852/diff/ > > > Testing > ------- > > Ran included unit tests. > > > Thanks, > > Gregory Chanan > >
