----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37469/#review95778 -----------------------------------------------------------
Ship it! Thanks for tackling this Anne! Test clean up looks much better now! - Sravya Tirukkovalur On Aug. 18, 2015, 8:12 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37469/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 8:12 p.m.) > > > Review request for sentry, Lenni Kuff and Sravya Tirukkovalur. > > > Bugs: SENTRY-850 > https://issues.apache.org/jira/browse/SENTRY-850 > > > Repository: sentry > > > Description > ------- > > Clean up more dbprovider test failures: run tests on a real cluster or > setMetastoreListener = true, if db/tab gets recreated their associated > privileges will be deleted. > > org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges > org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic > org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege > org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3 > org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended > org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1 > org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges > org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll > org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13 > org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10 > org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java > 9ed38ae > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbCrossDbOps.java > 8d23ea6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbExportImportPrivileges.java > e60225c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbJDBCInterface.java > f98caa9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMetadataObjectRetrieval.java > 9606b41 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java > a35cf21 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java > e1cda29 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java > 9fb6f7f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java > 5324656 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > 66e81a8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java > 43a310f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > f0d8ac4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > 659d820 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java > 58a27a6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestJDBCInterface.java > 194fe63 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java > 3a718e8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java > 30541d9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java > 8adc5bb > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java > 7c9a66d > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java > 46c6cbb > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java > c47686b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java > 626fd40 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java > 7c7c63e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > be9f601 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 2c14c82 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java > 30041c5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > c13222f > > Diff: https://reviews.apache.org/r/37469/diff/ > > > Testing > ------- > > https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console > > > Thanks, > > Anne Yu > >
