----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36833/#review95821 -----------------------------------------------------------
The code most looks good to me, one minor comment left. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java (line 34) <https://reviews.apache.org/r/36833/#comment150965> I think we should move **privilegesMap = new LinkedHashMap(); ** to constructor sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java (line 37) <https://reviews.apache.org/r/36833/#comment150964> I think we should move **privilegesMap = new LinkedHashMap(); ** here - Dapeng Sun On 八月 13, 2015, 1:08 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36833/ > ----------------------------------------------------------- > > (Updated 八月 13, 2015, 1:08 p.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Add new log entity for generic model > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestGMAuditMetadataLogEntity.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36833/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
