> On 十月 27, 2015, 4:32 p.m., shen guoquan wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java, > > line 178 > > <https://reviews.apache.org/r/39677/diff/2/?file=1108776#file1108776line178> > > > > It's better to execute "drop table if exists db2.tableName1" before to > > create it
Good suggestion, thank you for your comment. - Dapeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39677/#review104157 ----------------------------------------------------------- On 十月 27, 2015, 5:14 p.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39677/ > ----------------------------------------------------------- > > (Updated 十月 27, 2015, 5:14 p.m.) > > > Review request for sentry, Colin Ma and shen guoquan. > > > Bugs: SENTRY-915 > https://issues.apache.org/jira/browse/SENTRY-915 > > > Repository: sentry > > > Description > ------- > > Improve Hive E2E tests for keep consistent with Hive metadata > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java > d1f2774 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > 2e4be8a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java > f824cc5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataPermissions.java > 25d1f8c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java > 29b2d60 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java > 3f6f246 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java > 228a2de > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java > 6272752 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java > 6eb960b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java > fe837e4 > > Diff: https://reviews.apache.org/r/39677/diff/ > > > Testing > ------- > > > Thanks, > > Dapeng Sun > >
