----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40316/#review106532 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java (line 296) <https://reviews.apache.org/r/40316/#comment165241> Can you add a brief comment for this function explaining what it is doing ? Maybe add a TODO saying that we need a better mechanism from Hive to support this since it's brittle. sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java (line 321) <https://reviews.apache.org/r/40316/#comment165240> Can you do this once and just store all the results in a Set on startup? The code would then just look like: whitelistUdfsSet.contains(queryUdfs.toLower()); - Lenni Kuff On Nov. 13, 2015, 11:52 p.m., Ryan Pridgeon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40316/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 11:52 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > SENTRY-960: Bring whitelist validation back > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 18b8a8f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java > 23577c2 > > Diff: https://reviews.apache.org/r/40316/diff/ > > > Testing > ------- > > Ran the code in a live cluster to confirm it works > > Added unit test. > > > Thanks, > > Ryan Pridgeon > >
