----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42568/#review116035 -----------------------------------------------------------
Ship it! Ship It! - Dapeng Sun On 一月 22, 2016, 6:29 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42568/ > ----------------------------------------------------------- > > (Updated 一月 22, 2016, 6:29 a.m.) > > > Review request for sentry and Dapeng Sun. > > > Bugs: SENTRY-1012 > https://issues.apache.org/jira/browse/SENTRY-1012 > > > Repository: sentry > > > Description > ------- > > SENTRY-1012: Add core model for Kafka > > > Diffs > ----- > > pom.xml 6210454e87dc1fd3e6fc4abe10e42cf7b02591aa > sentry-core/pom.xml 59d32c4da0a6de77510d142efd006c345628c4a5 > sentry-core/sentry-core-model-kafka/pom.xml PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Cluster.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/ConsumerGroup.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Host.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionConstant.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionFactory.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaAuthorizable.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Topic.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/test/java/org/apache/sentry/core/model/kafka/TestKafkaAction.java > PRE-CREATION > > sentry-core/sentry-core-model-kafka/src/test/java/org/apache/sentry/core/model/kafka/TestKafkaAuthorizable.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42568/diff/ > > > Testing > ------- > > Added unit tests. Also covered via end-to-end tests as part of SENTRY-1014. > > > Thanks, > > Ashish Singh > >
