> On 一月 29, 2016, 10:45 a.m., Colin Ma wrote: > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java, > > line 361 > > <https://reviews.apache.org/r/42944/diff/1/?file=1225423#file1225423line361> > > > > The comment is also needed to be updated.
Thank Colin, I will update it on next patch. > On 一月 29, 2016, 10:45 a.m., Colin Ma wrote: > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java, > > line 481 > > <https://reviews.apache.org/r/42944/diff/1/?file=1225423#file1225423line481> > > > > The comment is also needed to be updated. Thank Colin, I will update it on next patch. - Dapeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42944/#review116880 ----------------------------------------------------------- On 一月 29, 2016, 10:24 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42944/ > ----------------------------------------------------------- > > (Updated 一月 29, 2016, 10:24 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1027 > https://issues.apache.org/jira/browse/SENTRY-1027 > > > Repository: sentry > > > Description > ------- > > Fix unused fields according PMD > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java > 9e72b78 > > Diff: https://reviews.apache.org/r/42944/diff/ > > > Testing > ------- > > Remove unused fields **grantorPrincipal at grantOrRevokePrivlegeOnRole** and > **grantOption at grantOrRevokePrivlegeOnRole** > > > Thanks, > > Dapeng Sun > >
