----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43242/#review117990 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java (line 481) <https://reviews.apache.org/r/43242/#comment179294> Are group names really case-insensitive? Linux groups are usually case-insensitive, AD groups are as well. While you are here can you fix toTrimedLower to spell "trimmed" properly? - Lenni Kuff On Feb. 5, 2016, 7:08 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43242/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 7:08 a.m.) > > > Review request for sentry and Gregory Chanan. > > > Repository: sentry > > > Description > ------- > > Group names are case insensitive, handle them as such in list apis. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > 78d38473f938b1aa2b357dd858b00f833147ee5d > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java > f1a87a83a97f3e2d7d06462abaaf4b983ab17677 > > Diff: https://reviews.apache.org/r/43242/diff/ > > > Testing > ------- > > Test already present, tweaked it to use mixed case. > > > Thanks, > > Sravya Tirukkovalur > >
