> On Feb. 23, 2016, 2:10 a.m., Dapeng Sun wrote:
> > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/HiveActionFactory.java,
> > line 57
> > <https://reviews.apache.org/r/43818/diff/1/?file=1263761#file1263761line57>
> >
> > return null?
The following is the useage for this method in CommonPrivilege, retrun null
means the action is not supported:
```
private boolean impliesAction(String policyValue, String requestValue,
BitFieldActionFactory bitFieldActionFactory) {
BitFieldAction currentAction =
bitFieldActionFactory.getActionByName(policyValue);
BitFieldAction requestAction =
bitFieldActionFactory.getActionByName(requestValue);
// the action in privilege is not supported
if (currentAction == null || requestAction == null) {
return false;
}
return currentAction.implies(requestAction);
}
```
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43818/#review120240
-----------------------------------------------------------
On Feb. 22, 2016, 2:50 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43818/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 2:50 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> For new external components, it should implement Model and
> BitFieldActionFactory.
> Implement Model and BitFieldActionFactory for Hive, Sqoop, Solr, Index.
>
>
> Diffs
> -----
>
>
> sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/HiveActionFactory.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/HivePrivilegeModel.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/IndexerPrivilegeModel.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchPrivilegeModel.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopPrivilegeModel.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43818/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
