Thanks Colin. Are there any timelines for this? If you're currently not actively working on this particular part, I can create a subtask of SENTRY-999 and work on a patch. I'm new to Sentry, so will look for suggestions, but is reading from configuration the recommended way?
- Bhooshan On Sun, Mar 6, 2016 at 5:45 PM, Ma, Junjie <[email protected]> wrote: > Hi Bhooshan, > > Currently, I'm working on the SENTRY-999 for the easy integration with > Sentry. I think the hardcoded map you pointed should be improved, make this > to be configurable or remove this. > Thanks for caught that. > > Best regards, > > Colin Ma(Ma Jun Jie) > > -----Original Message----- > From: Bhooshan Mogal [mailto:[email protected]] > Sent: Monday, March 7, 2016 12:40 AM > To: [email protected] > Subject: Hard coded actionFactories map in PrivilegeOperatePersistence > > Hi Folks, > > I'm trying to integrate our product with Sentry. I've hit a roadblock > because of a hardcoded map of component to ActionFactory at > https://github.com/apache/incubator-sentry/blob/master/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java#L51 > . > Is there a plan to make this configurable, since it prevents Sentry from > being truly extensible without modifying any core Sentry code? > > I wanted to find out if there is already some work underway to fix this > before exploring how this can be made configurable. I could not find much > after a quick glance at open jiras. I saw some discussion about > ActionFactory at https://issues.apache.org/jira/browse/SENTRY-999, but > that doesn't seem to include making this configurable. > > I saw that the Kafka integration also updates this map - > https://github.com/apache/incubator-sentry/blob/kafka/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java#L55 > , > so doesn't look like there is a way past this. > > Thanks in advance, > -- > Bhooshan > -- Bhooshan
