-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44400/#review122422
-----------------------------------------------------------




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/ConfServlet.java
 (line 45)
<https://reviews.apache.org/r/44400/#comment184409>

    format == null?



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/ConfServlet.java
 (line 53)
<https://reviews.apache.org/r/44400/#comment184410>

    Do we need to throw exception here for other format?


- Hao Hao


On March 7, 2016, 4:40 a.m., Li Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44400/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 4:40 a.m.)
> 
> 
> Review request for sentry, Anne Yu, Hao Hao, Lenni Kuff, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add servlet for dumping configurations
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/ConfServlet.java
>  PRE-CREATION 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java
>  9778c963c023244adfe4c0299ee1b372b1eddbc7 
>   sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html 
> f63097307f8359e650d9742d35a4683bec14a894 
> 
> Diff: https://reviews.apache.org/r/44400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Li Li
> 
>

Reply via email to