----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44539/#review122942 -----------------------------------------------------------
Ship it! Ship It! - Vamsee Yarlagadda On March 10, 2016, 1:52 a.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44539/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 1:52 a.m.) > > > Review request for sentry and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Currently, the impersonator info written by Sentry is always null: > > > String impersonator = null; // FIXME > > (https://github.com/apache/incubator-sentry/blob/b095b5b991a164983163390f0c8c6f78557d017e/sentry-solr/solr-sentry-core/src/main/java/org/apache/solr/sentry/SentryIndexAuthorizationSingleton.java#L129) > > Like with the user name, we should read out an http request attribute to fill > in this info. It is up to the underlying Solr authentication filter to fill > this info in; that's outside of the scope of Sentry, but this at least allows > that to be done. > > > Diffs > ----- > > > sentry-solr/solr-sentry-core/src/main/java/org/apache/solr/sentry/SentryIndexAuthorizationSingleton.java > c8f0560505f6ecfa783c06da85f5920fde732094 > > sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/sentry/SentryTestBase.java > fc137280567efb62de43837608b30df9035e6187 > > Diff: https://reviews.apache.org/r/44539/diff/ > > > Testing > ------- > > Running the unit tests and testing manually on a cluster. > > > Thanks, > > Gregory Chanan > >
