----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44677/#review123042 -----------------------------------------------------------
pom.xml (line 759) <https://reviews.apache.org/r/44677/#comment185175> Wondering why we need this? Seems like inherited is by default true? https://maven.apache.org/pom.html#Plugins pom.xml (line 778) <https://reviews.apache.org/r/44677/#comment185176> Sorry not familiar here, why do we need this? pom.xml (line 784) <https://reviews.apache.org/r/44677/#comment185177> Do we anticipate there will be no tests run? There is a slight chance of a green run if we skip the tests for unintended reasons. pom.xml (line 790) <https://reviews.apache.org/r/44677/#comment185178> Is there a reason why we do not want to reuse forks? pom.xml (line 793) <https://reviews.apache.org/r/44677/#comment185179> Ignore? sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java (line 62) <https://reviews.apache.org/r/44677/#comment185180> Just curious on what was the menthodology you used to know which tests are not thread safe? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 280) <https://reviews.apache.org/r/44677/#comment185169> Seems like we should fail the test if setup fails? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 298) <https://reviews.apache.org/r/44677/#comment185170> Same as above. Why are we not failing if setup fails? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 549) <https://reviews.apache.org/r/44677/#comment185171> Ah, I see that we are failing if the setup was unsuccessful here. But curious why are we moving the failing from @BeforeClass to @Before? - Sravya Tirukkovalur On March 10, 2016, 10:30 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44677/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 10:30 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1108 > https://issues.apache.org/jira/browse/SENTRY-1108 > > > Repository: sentry > > > Description > ------- > > First run unit tests concurrently, then sequentially for a selected > not-thread-safe tests. Improve the surefire plugin configurations to be more > robust, for example rerun failed tests more than once; Upgrade version to > 2.19; define unit test provider to be junit47 etc. > > Please help review the pom file changes, since they are criticial to > successfully and robustally run tests in the upstream. > > > Diffs > ----- > > pom.xml 5c31bf474dea40eee37d7162c7e75f32d042739d > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java > 726e3dcd97c4b851d040b182d20bc68f9a8c5ca3 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestURI.java > cdd4e0ba1c5f37ee64b39bb4262ad85e57a63000 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > 97c2e7153678a1680f54d2fe2baabc8a73ffc3aa > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestAuditLogForSentryGenericService.java > c3adacf52216b4ce331dbb92a06064ccd26aa043 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java > 921685a07795bec5a952d287b12da8d1c1e65166 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java > 6dbe7c0f562e7be65e807df41884b14467d68822 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestAuthorizingDDLAuditLogWithKerberos.java > 426b2f7abfd72b5688d69ec45caccfce47ff04c3 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceClientPool.java > e5285bd0a760bdcc7fe27e6af96d80ebc51d7dad > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java > a453ff3237662d4f45902473392f0d07b36bacea > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceForHAWithKerberos.java > 813b30b52c6d0dde6ca2c51a148a3dff7cb5cb0e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceForPoolWithKerberos.java > bd3c1ccba0a5b2e9863042f9a12f76b613c2041a > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > 0d35b7d66b452b1a37fbe5d838b41f84e2aea9e5 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithInvalidMsgSize.java > 09f3d8ed8919f00d27b4a6d1536992e41c820146 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithKerberos.java > ff73382664a243359aef0609f700c9ee4d04c0df > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithoutSecurity.java > 4a913e5189fa0aea7fb1770eb9f3e8e991289a50 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java > ded4b629579afacfe5ea0b6fabcb5e2be36eee2e > sentry-solr/solr-sentry-core/pom.xml > 44fbb864ad5828445c6358e7a0aa2eb34ebc65e5 > sentry-tests/sentry-tests-hive/pom.xml > 472cce7906a454af6f3a30edb8cc5760acaa0c25 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbConnections.java > 2af05360d8c5037a07fb3b838bd75a7c55bbdfa7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java > 883bedd95982ad92e91d9b5d53297714343f9391 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 704bbeeb9bd1c134398de82b2c20437226c9c4d1 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCustomSerdePrivileges.java > 27238154bb04b04a9fb3a640c09309c0e20252bf > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java > bb8d61d86730d7910c85a33c0fb3b066ba0d649a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > 054b1935975368db058791102f3892f027e31636 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrAdminOperations.java > c07b3b8efebca5693cddf84cc1a7104d9a7b17ee > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrDocLevelOperations.java > 7f1fdfdbe2edbf7b340693ea1045470efc79b043 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrQueryOperations.java > 3eb6c0f0250e0e6cd8362cd63b7988423d120d80 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrUpdateOperations.java > 94123259ab9f9ac90cc3a6d1978f4df7af3f0425 > > Diff: https://reviews.apache.org/r/44677/diff/ > > > Testing > ------- > > > Thanks, > > Anne Yu > >
