> On March 17, 2016, 5:35 a.m., Lenni Kuff wrote: > > sentry-provider/sentry-provider-db/pom.xml, line 227 > > <https://reviews.apache.org/r/44501/diff/2/?file=1299068#file1299068line227> > > > > Maybe split the change to include the githash into a separate JIRA to > > make it easier view when this change came in in the code history
Created jira SENTRY-1141 for githash > On March 17, 2016, 5:35 a.m., Lenni Kuff wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java, > > line 70 > > <https://reviews.apache.org/r/44501/diff/2/?file=1299069#file1299069line70> > > > > maybe log that SSL mode is being used? Done > On March 17, 2016, 5:35 a.m., Lenni Kuff wrote: > > sentry-provider/sentry-provider-db/pom.xml, line 229 > > <https://reviews.apache.org/r/44501/diff/2/?file=1299068#file1299068line229> > > > > what happens if you build the raw source (no git available) will be an empty string > On March 17, 2016, 5:35 a.m., Lenni Kuff wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java, > > line 72 > > <https://reviews.apache.org/r/44501/diff/2/?file=1299069#file1299069line72> > > > > Some SSL protocols are not secure (remember poodle?). I think we will > > want to have a way to blacklist these. Jetty should provide a way to pass > > in the excluded protocols. Thanks for your remind. Will update it. - Li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44501/#review123983 ----------------------------------------------------------- On March 15, 2016, 1:21 a.m., Li Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44501/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 1:21 a.m.) > > > Review request for sentry, Anne Yu, Hao Hao, Lenni Kuff, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Add SSL support, print version info on Sentry Service webpage > > > Diffs > ----- > > sentry-provider/sentry-provider-db/pom.xml > 1dbfad49f7b9bb1b963221600bbd8d0400ab8d5d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java > 1bdea2c55de12a999f94ea33f8709311c7c2c7f2 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 94bd2a95c77a9691cbaa578ebf417e49c339b7ed > sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html > cd19dd8b9a228e56800bd06f0714a5ab17634347 > sentry-provider/sentry-provider-db/src/main/webapp/css/sentry.css > e5b3d437406a881e78494547791e1b26bb4f2bc8 > > Diff: https://reviews.apache.org/r/44501/diff/ > > > Testing > ------- > > > Thanks, > > Li Li > >
