No this wasn’t needed.
I first intended to add the macro there, but then I found out that it only really applied to debugging. Thanks for the review! Bert From: Greg Stein [mailto:gst...@gmail.com] Sent: dinsdag 3 november 2015 13:41 To: Bert Huijben <rhuij...@apache.org> Cc: dev@serf.apache.org Subject: Re: svn commit: r1712270 - in /serf/trunk: buckets/allocator.c buckets/buckets.c test/test_util.c On Tue, Nov 3, 2015 at 6:12 AM, <rhuij...@apache.org <mailto:rhuij...@apache.org> > wrote: >... +++ serf/trunk/buckets/allocator.c Tue Nov 3 12:12:00 2015 @@ -27,6 +27,8 @@ #include "serf.h" #include "serf_bucket_util.h" +#include "serf_private.h" Is this really needed? The changes don't seem to require exposure to the private header. >... Cheers, -g