svn commit: r1715764 - in /serf/trunk/buckets: event_buckets.c fcgi_buckets.c

[rhuijben]

Author: rhuijben
Date: Mon Nov 23 11:14:55 2015
New Revision: 1715764

URL: http://svn.apache.org/viewvc?rev=1715764&view=rev
Log:
Fix some issues identified by clang.

* buckets/event_buckets.c
  (serf_event_set_config): Mark static.

* buckets/fcgi_buckets.c
  (fcgi_handle_keypair): Mark static.
  (fcgi_params_decode): Mark static. Fix expression.

Modified:
    serf/trunk/buckets/event_buckets.c
    serf/trunk/buckets/fcgi_buckets.c

Modified: serf/trunk/buckets/event_buckets.c
URL: 
http://svn.apache.org/viewvc/serf/trunk/buckets/event_buckets.c?rev=1715764&r1=1715763&r2=1715764&view=diff
==============================================================================
--- serf/trunk/buckets/event_buckets.c (original)
+++ serf/trunk/buckets/event_buckets.c Mon Nov 23 11:14:55 2015
@@ -199,8 +199,8 @@ static apr_uint64_t serf_event_get_remai
     }
 }
 
-apr_status_t serf_event_set_config(serf_bucket_t *bucket,
-                                   serf_config_t *config)
+static apr_status_t serf_event_set_config(serf_bucket_t *bucket,
+                                          serf_config_t *config)
 {
     event_context_t *ctx = bucket->data;
 

Modified: serf/trunk/buckets/fcgi_buckets.c
URL: 
http://svn.apache.org/viewvc/serf/trunk/buckets/fcgi_buckets.c?rev=1715764&r1=1715763&r2=1715764&view=diff
==============================================================================
--- serf/trunk/buckets/fcgi_buckets.c (original)
+++ serf/trunk/buckets/fcgi_buckets.c Mon Nov 23 11:14:55 2015
@@ -331,7 +331,7 @@ static apr_size_t size_data_requested(fc
     return requested;
 }
 
-void fcgi_handle_keypair(serf_bucket_t *bucket)
+static void fcgi_handle_keypair(serf_bucket_t *bucket)
 {
     fcgi_params_decode_ctx_t *ctx = bucket->data;
     char *key = ctx->key;
@@ -380,7 +380,7 @@ void fcgi_handle_keypair(serf_bucket_t *
     serf_bucket_mem_free(bucket->allocator, val);
 }
 
-apr_status_t fcgi_params_decode(serf_bucket_t *bucket)
+static apr_status_t fcgi_params_decode(serf_bucket_t *bucket)
 {
     fcgi_params_decode_ctx_t *ctx = bucket->data;
     apr_status_t status = APR_SUCCESS;
@@ -491,7 +491,7 @@ apr_status_t fcgi_params_decode(serf_buc
     }
 
     if (APR_STATUS_IS_EOF(status)) {
-        if (ctx->state == DS_SIZES && !ctx->tmp_size
+        if ((ctx->state == DS_SIZES && !ctx->tmp_size)
             || (ctx->state == DS_KEY && !ctx->key_sz && !ctx->val_sz))
         {
             return APR_SUCCESS;