On 15.12.2016 18:16, Ivan Zhakov wrote: > On 15 December 2016 at 17:31, <br...@apache.org> wrote: >> +/* >> + * OCSP bits are here because they depend on OpenSSL and private types >> + * defined in this file. >> + */ >> + >> +struct serf_ssl_ocsp_request_t { >> +#ifndef OPENSSL_NO_OCSP >> + /* OpenSSL's internal representation of the OCSP request. */ >> + OCSP_REQUEST *request; >> + >> + /* DER-encoded request and size. */ >> + const void *der_request; >> + apr_size_t der_request_size; >> + >> + /* Exported server and issuer certificates. */ >> + const char *encoded_server_cert; >> + const char *encoded_issuer_cert; >> +#endif /* OPENSSL_NO_OCSP */ >> +}; > As far I remember C requires that a struct or union has at least one member.
You're absolutely right. I've been meddling in C++ for too long. FWIW, that file does not compile, even on trunk, when OPENSSL_NO_OCSP is defined ... I wonder if we should just remove those conditional blocks? After all, it's not as if we want to encourage people to use OpenSSL 0.9.7. -- Brane