Author: kotkov
Date: Thu Aug 17 23:03:36 2017
New Revision: 1805341
URL: http://svn.apache.org/viewvc?rev=1805341&view=rev
Log:
* STATUS: Nominate r1804534, r1804543 and r1804553 (Fix error handling
when reading the outgoing request's body).
Modified:
serf/branches/1.3.x/STATUS
Modified: serf/branches/1.3.x/STATUS
URL:
http://svn.apache.org/viewvc/serf/branches/1.3.x/STATUS?rev=1805341&r1=1805340&r2=1805341&view=diff
==============================================================================
--- serf/branches/1.3.x/STATUS (original)
+++ serf/branches/1.3.x/STATUS Thu Aug 17 23:03:36 2017
@@ -19,6 +19,25 @@ Candidate changes:
Votes:
+1: stsp, astieger
+ * r1804534, r1804543, r1804553
+ Fix error handling when reading the outgoing request's body by not
+ ignoring such errors in some cases.
+ Justification:
+ Ignoring errors can cause invalid or undefined behavior further
+ down the line.
+ Branch:
+ ^/serf/branches/1.3.x-fix-outgoing-request-err
+ Notes:
+ - On trunk, this issue has been fixed in the process of adding
+ the pump.c layer.
+ - An example of a condition where the error could be incorrectly ignored
+ is Subversion's commit, if the error occurs when reading the body of
+ an outgoing PUT request.
+ - The added test doesn't fail without the fix, but is merely added to
+ cover the related code. (See the r1804541 log message for details.)
+ Votes:
+ +1: kotkov
+
Veto-blocked changes:
=====================