On Tue, Mar 31, 2020 at 09:39:12AM -0400, Justin Erenkrantz wrote: > In reviewing your Python 3.x patches, I noticed a change to build/gen_def.py ; > in my local tests, it didn't seem to be required; plus, trunk/1.4.x has a > slightly different patch.
The changes for gen_def.py in the 1.3.x patch I provided weren't strictly necessary for Python 3, but it's better management of resources (ensuring the fname filehandle gets closed). Not a big deal in this case, since it's a short-lived script but better practice in general. > I'm leaning towards just backporting the change > below; but, it doesn't seem to make a material difference either way as far as > I can tell. Do you (or anyone else) have any additional backstory here as to > why the change is required? Based on r1699621, it looks like that was general cleanup so extract_exports() didn't need to create a list that was going to be turned into a set anyway -- just deal with a set from the start. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
