On 29.12.2020 22:35, Justin Erenkrantz wrote:
The OpenSSL devs intended this to be a breaking change - but it's not
documented anywhere. Sigh.
I've got a WIP patch against trunk that causes test_ssl to pass - see
below. It also seems to work with OpenSSL 1.1.1h as well as OpenSSL 1.1.1i
/ 1.1.1-stable, AFAICT.
Justin, could you please apply said patch to 1.4.x at least?
I'm trying to build SVN for Apple Silicon, and I've ran into a problem
where Apple Silicon is only supported since OpenSSL 1.1.1h, but at the
same time serf tests fail starting with OpenSSL 1.1.1h.
With your patch, it's good. I also took time to understand the problem
and I believe that your patch is correct, except maybe I would rather
define a new error code just next to 'SERF_ERROR_ISSUE_IN_TESTSUITE',
with a name like 'SERF_ERROR_EXPECTED_IN_TESTSUITE' and use that instead
of 'APR_EGENERAL' which is a bit too general :)
