Hi Denis, On Fri, 17 Jun 2022 at 14:59, Denis Kovalchuk <denis.kovalc...@visualsvn.com.invalid> wrote:
> Hi! > > I would like to propose a refactoring of the bio_bucket_ctrl() function in > the > ssl_bucket.c file: > > - Return values from case statements and get rid of the ret variable. The > control flow is more explicit and clear. > > I personally prefer the "we return an error by default unless we explicitly addressed the situation" attitude. So for me this part of your patch doesn't provide an improvement. > - Move the default statement to the end of the switch. It's more common for > switch statements. > > Yeah, the default case at the bottom is indeed more common. If you are working on bigger changes in the ssl code you can include this modification AFAIC. > What do you think? > > Kind Regards, > Denis Kovalchuk > regards, Lieven
