gstein commented on code in PR #9:
URL: https://github.com/apache/serf/pull/9#discussion_r2211115866
##########
buckets/ssl_buckets.c:
##########
@@ -1877,7 +1915,7 @@ static int ssl_need_client_cert(SSL *ssl, X509 **cert,
EVP_PKEY **pkey)
return 1;
}
else {
- int err = ERR_get_error();
+ err = ERR_get_error();
ERR_clear_error();
Review Comment:
Also agree. All variables should be scoped as tightly as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@serf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
