On 15. 3. 26 17:21, Timofei Zhakov wrote:
Hi All,Building Serf 1.3.10 on Windows with MSVC 14.5 using SCons build system currently fails because the "MSVC version is not recognised". Also the error is only generated when making a Debug build. The error message looks like this: [[[ scons: *** Invalid value for enum variable 'MSVC_VERSION': '14.5'. Valid values are: ('14.3', '14.2', '14.1', '14.0', '12.0', '11.0', '10.0', '9.0', '8.0', '6.0') ]]] After some investigation, I found that there is an explicit list of what versions are supported [1]. However, I didn't find any references to the variable it sets (MSVC_VERSION). I'm not an expert in scons. Perhaps someone else could point out how this actually works, but from my perspective I don't see a reason for this parameter to exist in the first place. If it's a scons thing, that it requires that variable to be pre-configured, at least I don't think we should explicitly limit compiler versions to a specific collection of values.
With MSVC, you never know...
I think a minor change update of the compiler should not be causing a well-functioning build configuration to suddenly start failing.
Just add 14.5 to the list. And probably remove anything older than, what, 10? I don't think the versions of Windows that used those compilers even exist any more, except possibly in some strange airgapped environment that may as well use an older version of Serf.
-- Brane
