weichao666 commented on a change in pull request #591: [SCB-396] java-sdk needs to distinguish the services belongs to the devops stage(environment) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#discussion_r174663587
########## File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java ########## @@ -60,6 +62,7 @@ private Microservice createMicroserviceFromDefinition(Configuration configuratio microservice.setPaths(ConfigurePropertyUtils.getMicroservicePaths(configuration)); Map<String, String> propertiesMap = MicroservicePropertiesLoader.INSTANCE.loadProperties(configuration); microservice.setProperties(propertiesMap); + microservice.setEnvironment(configuration.getString(SERVICECOMB_ENV, DEFAULT_SERVICECOMB_ENV)); Review comment: ![image](https://user-images.githubusercontent.com/30716999/37441602-377a004a-283d-11e8-8406-ef38fc13714b.png) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services