wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r178419789
########## File path: swagger/swagger-invocation/invocation-validator/src/main/java/org/apache/servicecomb/swagger/invocation/validator/ParameterValidator.java ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.servicecomb.swagger.invocation.validator; + +import java.util.Set; + +import javax.validation.ConstraintViolation; +import javax.validation.ConstraintViolationException; +import javax.validation.Validation; +import javax.validation.ValidatorFactory; +import javax.validation.executable.ExecutableValidator; +import javax.validation.groups.Default; + +import org.apache.servicecomb.swagger.engine.SwaggerProducerOperation; +import org.apache.servicecomb.swagger.invocation.SwaggerInvocation; +import org.apache.servicecomb.swagger.invocation.extension.ProducerInvokeExtension; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class ParameterValidator implements ProducerInvokeExtension { + + private static final Logger LOGGER = LoggerFactory.getLogger(ParameterValidator.class); + + private static ExecutableValidator executableValidator; + + @Override + public <T> void beforeMethodInvoke(SwaggerInvocation invocation, SwaggerProducerOperation producerOperation, + Object[] args) + throws ConstraintViolationException { + + if (null == executableValidator) { + ValidatorFactory factory = Validation.buildDefaultValidatorFactory(); + executableValidator = factory.getValidator().forExecutables(); + } + Set<ConstraintViolation<Object>> violations = + executableValidator.validateParameters(producerOperation.getProducerInstance(), + producerOperation.getProducerMethod(), + args, + Default.class); + if (violations.size() > 0) { + LOGGER.warn("Parameter validation failed : " + violations.toString()); + throw new ConstraintViolationException(violations.toString(), violations); + } + } + + @Override + public int getOrder() { + return 100; Review comment: default to 100 is not enough. order rule is: smaller order have high priority so what will happened in ExceptionToResponseConverters when developers custom their own ConstraintViolationException converter? had remind you this yesterday...... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
