WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc
rest vertx file download
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182294300
##########
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/InputStreamToReadStream.java
##########
@@ -34,7 +34,7 @@
public class InputStreamToReadStream implements ReadStream<Buffer> {
private static final Logger LOGGER =
LoggerFactory.getLogger(InputStreamToReadStream.class);
- public static final int DEFAULT_READ_BUFFER_SIZE = 8192;
+ public static final int DEFAULT_READ_BUFFER_SIZE = 1024 * 1024;
Review comment:
We may need to mention it in the release note.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
