wujimin commented on a change in pull request #651: [SCB-498] Configuration
Center ip address need to config default port
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182779209
##########
File path:
foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
##########
@@ -49,6 +49,10 @@ public void testNetutils() {
Assert.assertEquals(NetUtils.parseIpPortFromURI(null), null);
Assert.assertEquals(NetUtils.parseIpPortFromURI("ss"), null);
Assert.assertEquals(NetUtils.parseIpPortFromURI("rest://127.0.0.1:8080").getHostOrIp(),
"127.0.0.1");
+
Assert.assertEquals(NetUtils.parseIpPortFromURI("http://127.0.0.1:8080";).getPort(),
8080);
Review comment:
expect value is the first parameter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
