wujimin commented on a change in pull request #648: [SCB-482] Http2 support for
java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182782472
##########
File path:
transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##########
@@ -127,7 +127,9 @@ private HttpServerOptions createDefaultHttpServerOptions()
{
serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
serverOptions.setCompressionSupported(TransportConfig.getCompressed());
serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
-
+ if (endpointObject.isHttp2Enabled()) {
Review comment:
this means h2 mode?
but how h2c can work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
