WillemJiang commented on a change in pull request #181: [SCB-342] Add TLS
support for gRPC
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r185719814
##########
File path:
alpha/alpha-server/src/test/java/org/apache/servicecomb/saga/alpha/server/AlphaIntegrationTest.java
##########
@@ -134,6 +150,23 @@
private final CompensationStreamObserver compensateResponseObserver = new
CompensationStreamObserver(
this::onCompensation);
+ private static SslContext getSslContext(){
+ ClassLoader classLoader = AlphaIntegrationTest.class.getClassLoader();
+ SslContext sslContext = null;
+ try {
+ sslContext = GrpcSslContexts.forClient().sslProvider(SslProvider.OPENSSL)
+ .protocols("TLSv1.2","TLSv1.1")
+ .ciphers(Arrays.asList("ECDHE-RSA-AES128-GCM-SHA256",
+ "ECDHE-RSA-AES256-GCM-SHA384",
+ "ECDHE-ECDSA-AES128-SHA256"))
+ .trustManager(new File(classLoader.getResource("ca.crt").getFile()))
Review comment:
I think we need to use the environment property instead of hard code here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
