wujimin commented on a change in pull request #691: [SCB-546] refactor the
schemas registry logic
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/691#discussion_r186635529
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
##########
@@ -136,19 +140,48 @@ private boolean checkSchemaIdSet() {
}
private boolean registerSchemas() {
+ List<GetSchemaResponse> existSchemas =
srClient.getSchemas(microservice.getServiceId());
for (Entry<String, String> entry : microservice.getSchemaMap().entrySet())
{
String schemaId = entry.getKey();
String content = entry.getValue();
-
- boolean exists = srClient.isSchemaExist(microservice.getServiceId(),
schemaId);
- LOGGER.info("schemaId {} exists {}", schemaId, exists);
+ GetSchemaResponse existSchema = extractSchema(schemaId, existSchemas);
+ boolean exists = existSchema == null ? false : true;
+ LOGGER.info("schemaId [{}] exists {}", schemaId, exists);
if (!exists) {
if (!srClient.registerSchema(microservice.getServiceId(), schemaId,
content)) {
return false;
}
+ } else {
+ String curSchemaSumary = existSchema.getSummary();
+ String schemaSummary = Hashing.md5().newHasher().putString(content,
Charsets.UTF_8).hash().toString();
+ if (!schemaSummary.equals(curSchemaSumary)) {
+ if (microservice.getInstance().getEnvironment().startsWith("dev")) {
+ LOGGER.info(
+ "schemaId [{}]'s content changes and the current enviroment is
development, so re-register it!",
+ schemaId);
+ srClient.registerSchema(microservice.getServiceId(), schemaId,
content);
+ } else {
+ throw new RuntimeException("schemaId [" + schemaId
Review comment:
IllegalStateException is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
