liubao68 commented on a change in pull request #648: [SCB-482] Http2 support
for java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r186657701
##########
File path: demo/demo-pojo/pojo-server/src/main/resources/microservice.yaml
##########
@@ -24,7 +24,7 @@ servicecomb:
registry:
address: http://127.0.0.1:30100
rest:
- address: 0.0.0.0:8080
+ address: 0.0.0.0:8080?protocol=h2
Review comment:
It's better to use protocol=http2, because
1. protocol=http2 + sslEnabled=true means h2
2. protocol=http2 + sslEnabled=false means h2c
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
