In my opinion, I'd prefer not include Lombok in our project. Here my reasons: 1. It's a convenient tool to write getters and setters, users can include it very easily to their projects. 2. For framework, I'd prefer our class do not use Lombok annotations. Because write getters/setters is very potable to very runtime,and quite easy with an IDE. We can avoid many troubles related to 3rdparty dependencies, licenses and maybe conflicts. 3. Some of our customers using Lombok before, there are some know issues regarding to java bean specification or work together with Json libraries. (Sorry I do not have the details)
------------------ ???????? ------------------ ??????: "willem.jiang"<willem.ji...@gmail.com>; ????????: 2018??8??22??(??????) ????3:40 ??????: "dev"<dev@servicecomb.apache.org>; ????: Re: About introduce Lombok to service comb We could specify it in the environment setup document. @Cherry Could you share the experience of Lombok usage in sharding sphere? Willem Jiang Twitter: willemjiang Weibo: ????willem On Wed, Aug 22, 2018 at 2:13 PM, wjm wjm <zzz...@gmail.com> wrote: > everyone clone our code, if need to load by IDE, must install the IDE > plugin, i don't think it's a good idear. > > 2018-08-22 12:33 GMT+08:00 Zheng Feng <zh.f...@gmail.com>: > > > It looks good to me and the lombok supports the JDK 9 ? > > > > 2018-08-22 12:21 GMT+08:00 ???? <zhaoju...@jd.com>: > > > > > Hi, Willem > > > > > > Lombok would not package into our service-comb jar, so there is no > > license > > > issue. > > > We can set the maven scope is ??provide??, it just enhance the java code > > > byte in compile step. > > > > > > > > > > > > > On 21 Aug 2018, at 10:57 PM, wjm wjm <zzz...@gmail.com> wrote: > > > > > > > > in fact, getter / setter and so on can be generated by IDE(IntelliJ / > > > > Eclipse) simply > > > > > > > > 2018-08-21 22:34 GMT+08:00 Willem Jiang <willem.ji...@gmail.com>: > > > > > > > >> Hi Cherry, > > > >> > > > >> Thanks for proposal, it can save us lot of time when we write the > java > > > bean > > > >> class. > > > >> As lombok is using MIT license, I don't think we could have the > > license > > > >> issue here. > > > >> > > > >> I think we can start it from saga project, it's up to java-chassis > to > > > check > > > >> if it want to use it. > > > >> > > > >> @Team Any thought? > > > >> > > > >> > > > >> > > > >> Willem Jiang > > > >> > > > >> Twitter: willemjiang > > > >> Weibo: ????willem > > > >> > > > >> On Tue, Aug 21, 2018 at 12:58 PM, cherrylzhao <zhaoju...@126.com> > > > wrote: > > > >> > > > >>> Hi, all > > > >>> > > > >>> Lombok can simplify our work for creating java entity. > > > >>> Using Lombok annotation, it will enhance java byte code within > > compile > > > >>> step. > > > >>> We can use @Getter @Setter @Log @RequiredArgsConstructor to define > > our > > > >>> model simplify. > > > >>> See more detail from https://projectlombok.org < > > > >> https://projectlombok.org/ > > > >>>> > > > >>> > > > >>> any thought? > > > >> > > > > > > > > >
