Hi,
It seems to me that just changing the spring/springboot version is not
enough. There might be inconsistent implementation details which will
require code change between spring 4.x and spring 5.x.
It's better that we remove spring dependency from those none spring related
modules, and then using profile or a separate dependency pom for managing
the spring version.
Modules depends on spring:
ybo@yangbo:~/repos/incubator-servicecomb-java-chassis$ find . -type f -name
"pom.xml" -exec grep -l spring {} \; | grep -v demo | grep -v samples |
grep -v spring-boot | grep -v tests
./transports/transport-rest/transport-rest-servlet/pom.xml
./archetypes/business-service-jaxrs/target/classes/archetype-resources/pom.xml
./archetypes/business-service-jaxrs/src/main/resources/archetype-resources/pom.xml
./archetypes/business-service-springmvc/target/classes/archetype-resources/pom.xml
./archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
./archetypes/business-service-springmvc/pom.xml
./archetypes/pom.xml
./java-chassis-distribution/pom.xml
./dynamic-config/config-apollo/pom.xml
./parent/pom.xml
./tracing/tracing-zipkin/pom.xml
./tracing/pom.xml
./java-chassis-dependencies/pom.xml
./pom.xml
./handlers/handler-tracing-zipkin/pom.xml
./providers/pom.xml
./providers/provider-springmvc/pom.xml
./coverage-reports/pom.xml
./swagger/swagger-generator/pom.xml
./swagger/swagger-generator/generator-springmvc/pom.xml
./swagger/swagger-invocation/invocation-springmvc/pom.xml
./swagger/swagger-invocation/invocation-core/pom.xml
./swagger/swagger-invocation/pom.xml
./foundations/foundation-config/pom.xml
./foundations/foundation-test-scaffolding/pom.xml
./foundations/foundation-common/pom.xml
On Thu, Sep 13, 2018 at 9:42 AM 郑扬勇 <yangyong.zh...@qq.com> wrote:
> Hi all:
> Spring boot 2.0 had released for a long time ,so I think we need
> support it as soon as possible.
> Here is our current dependency relationship :
>
> java-chassis [pom]
> ↑
> java-chassis-dependencies(import springboot 1.5.x and spring4.3.x etc)
> [pom]
> ↑
> java-chassis-parent (docker & jacoco plugin etc) [pom]
> ↑
> core,edge,handler etc [jar]
>
> So I think we can do like this for support spring boot 2.0:
>
> java-chassis [pom]
> ↑
> * java-chassis-dependencies-springboot2 (FIRST import springboot 2.0.x
> and spring5.0.x ,THEN import java-chassis-dependencies) [pom]
> ↑
> spring-boot2-starter-servlet(for support Embedded tomcat) etc [jar]
>
> Any thoughts?
> Best Regards & Thanks!
> Yangyong Zheng
--
Best Regards,
Yang.
