Hi, Willem

Now @Transactional Aspect is last one to the wrapper without the @order 
annotation.
I’ll send a PR to clean up @order later.

> On 17 Sep 2018, at 2:25 PM, Willem Jiang <[email protected]> wrote:
> 
> Hi Cherry,
> 
> Thanks for sharing this information with us.  Normally we just need
> make sure @Transactional Aspect is last one to the wrapper.
> Can you send a PR by clean up the order thing?
> 
> Willem Jiang
> 
> Twitter: willemjiang
> Weibo: 姜宁willem
> 
> On Mon, Sep 17, 2018 at 12:21 PM cherrylzhao <[email protected]> wrote:
>> 
>> Hi
>> 
>> I found that @order annotation can’t work in TransactionAspectConfig.java.
>> Now, we define the @order(0), @order(1) in Aspect beans, but when I adjust 
>> the value of order,
>> The aspect chains of dynamic proxy bean can’t change.
>> 
>> It seems that @order annotation can work with @Aspect annotation, so we need 
>> move the @order to the head of aspect bean like this:
>> -----
>> @Aspect
>> @Order(0)
>> public class SagaStartAspect {}
>> 
>> But this need omega-transaction module add spring dependency,it will 
>> increase the coupling of omega module.
>> Also we can remove the @order annotation from TransactionAspectConfig.java,
>> so the default order is lowest and SagaStartAspect will be inside the 
>> @Transactional.
>> 
>> 
>> Best Wishes & Regards
>> 
>> 

Reply via email to