Do we have some conclusion for this issue? Willem Jiang
Twitter: willemjiang Weibo: 姜宁willem On Fri, Sep 28, 2018 at 11:23 AM Willem Jiang <[email protected]> wrote: > > Hi > > I think we should give user a chance to override the > spring-boot-dependencies version as they want. > Current we just have the spring-boot 1.x dependencies in the > java-chassis dependencies. > > As there are some servlet related change between spring-boot-1.x and > spring-boot-2.x we may need to provide a separate modules to support > spring-boot-1.x and spring-boot-2.x, in this way we may need to > introduce the dependencies ourselves. > > I think user can override the spring-boot version by adding the > dependencies management as Liubao proposed, but he still need to take > care servlet API change part to pick up the right servlet module. If > we don't want to add another dependencies pom in the java-chassis, we > should document it at least. > > Just my two cents. > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Tue, Sep 25, 2018 at 4:39 AM bismy <[email protected]> wrote: > > > > In PR[1] add a new dependency management for spring boot2, that is > > java-chassis-dependencies-springboot2/pom.xml > > > > > > This file is a bit huge and I think we can simplify by adding > > > > > > <dependencyManagement> > > <dependencies> > > <dependency> > > <!-- Import dependency management from Spring Boot > > --> > > <groupId>org.springframework.boot</groupId> > > <artifactId>spring-boot-dependencies</artifactId> > > <version>2.0.5.RELEASE</version> > > <type>pom</type> > > <scope>import</scope> > > </dependency> > > </dependencies> > > </dependencyManagement> > > > > > > > > Do we have any special reasons that do not use this feature provided by > > spring boot? > > > > > > [1]https://github.com/apache/incubator-servicecomb-java-chassis/pull/906/files
