Hi wjm PR 1168, just added an application id , I think it should be fine to be part of java-chassis 1.2.0. Please verify it.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Apr 5, 2019 at 9:33 PM wjm wjm <zzz...@gmail.com> wrote: > > yes, need some fix. > > https://github.com/apache/servicecomb-java-chassis/pull/1167 already > merged. > https://github.com/apache/servicecomb-java-chassis/pull/1168 not > merged, need review and merge. > > > Willem Jiang <willem.ji...@gmail.com> 于2019年4月5日周五 下午3:40写道: > > > Hi Asif > > > > As the CI is not unstable recently, we need to include the fix of > > this PR[1] to fix it. > > So I have to vote -1 for this release. > > > > > > [1]https://github.com/apache/servicecomb-java-chassis/pull/1167 > > > > Willem Jiang > > > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Thu, Apr 4, 2019 at 12:25 AM Mohammad Asif Siddiqui > > <asifdxtr...@apache.org> wrote: > > > > > > Hello All, > > > > > > This is a call for a Vote to release Apache ServiceComb Java-Chassis > > > version 1.2.0 > > > > > > Release Notes : > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344561 > > > > > > > > > Release Candidate : > > > > > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-java-chassis/1.2.0/rc-01/ > > > > > > > > > Staging Repo : > > > > > https://repository.apache.org/content/repositories/orgapacheservicecomb-1382 > > > > > > > > > Release Tag : > > > https://github.com/apache/servicecomb-java-chassis/releases/tag/1.2.0 > > > > > > Release CommitID : 00c1d8e8324c358acdd3084ed5473c7f99270168 > > > > > > Keys to verify the Release Candidate : > > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS > > > > > > Voting will start now ( Wednesday, 3rd April, 2019) and will remain open > > > for at-least 72 hours, Request all PMC members to give their vote. > > > > > > [ ] +1 Release this package as 1.2.0 > > > [ ] +0 No Opinion > > > [ ] -1 Do not release this package because.... > > > > > > On the behalf of ServiceComb Team > > > Mohammad Asif Siddiqui > >